nvme/023: use character device for nvme smart-log command#173
Closed
yizhanglinux wants to merge 1 commit intolinux-blktests:masterfrom
Closed
nvme/023: use character device for nvme smart-log command#173yizhanglinux wants to merge 1 commit intolinux-blktests:masterfrom
yizhanglinux wants to merge 1 commit intolinux-blktests:masterfrom
Conversation
The nvme-cli v2.12 changed to use the character device for nvme smart-log command, update nvme/023 to use char device to avoid the case failure. $ nvme smart-log /dev/nvme0n1 smart log: No such device or address $ nvme smart-log /dev/nvme0 Smart Log for NVME device:nvme0 namespace-id:ffffffff critical_warning : 0 temperature : -459 °F (0 K) available_spare : 0% available_spare_threshold : 0% percentage_used : 0% endurance group critical warning summary: 0 Data Units Read : 20 (10.24 MB) Data Units Written : 0 (0.00 B) host_read_commands : 142 host_write_commands : 0 controller_busy_time : 0 power_cycles : 0 power_on_hours : 0 unsafe_shutdowns : 0 media_errors : 0 num_err_log_entries : 0 Warning Temperature Time : 0 Critical Composite Temperature Time : 0 Thermal Management T1 Trans Count : 0 Thermal Management T2 Trans Count : 0 Thermal Management T1 Total Time : 0 Thermal Management T2 Total Time : 0 Link: linux-blktests#172 Signed-off-by: Yi Zhang <[email protected]>
Contributor
|
LGTM. Thanks! |
Collaborator
|
Ah, I wasn't aware of this PR and the related issue #172. And did the investigation in parallel...
Based on these, I'm still not sure if really nvme-cli drops the namespace block device support for the "nvme smart-log" command. |
Contributor
Author
|
Thanks for the investigation. Let's hold the change until we have the final conclusion for "nvme smart-log." |
Contributor
|
We have a couple of places we are discussing things. I'll keep linux-nvme/nvme-cli#2829 updated what's going on in libnvme/nvme-cli resp. the mailing list. |
Contributor
|
I've applied the fix for libnvme. The io_uring usage is borderline useful IMO. Maybe we should document that it is not necessary to be enabled for distro packages. |
Contributor
Author
|
Close it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nvme-cli v2.12 changed to use the character device for nvme smart-log command, update nvme/023 to use char device to avoid the case failure.
$ nvme smart-log /dev/nvme0n1
smart log: No such device or address
$ nvme smart-log /dev/nvme0
Smart Log for NVME device:nvme0 namespace-id:ffffffff critical_warning : 0
temperature : -459 °F (0 K)
available_spare : 0%
available_spare_threshold : 0%
percentage_used : 0%
endurance group critical warning summary: 0
Data Units Read : 20 (10.24 MB)
Data Units Written : 0 (0.00 B)
host_read_commands : 142
host_write_commands : 0
controller_busy_time : 0
power_cycles : 0
power_on_hours : 0
unsafe_shutdowns : 0
media_errors : 0
num_err_log_entries : 0
Warning Temperature Time : 0
Critical Composite Temperature Time : 0
Thermal Management T1 Trans Count : 0
Thermal Management T2 Trans Count : 0
Thermal Management T1 Total Time : 0
Thermal Management T2 Total Time : 0
Link: #172